Add Docker Support #2486
Merged
Add Docker Support #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingRainbow44
requested changes
Mar 17, 2024
|
Just out of curiosity, why is the npm/nodejs update /install required in the docker script? |
|
presumably for handbook generation; but since it requires extra data, it was skipped anyways |
I added it for handbook generation, makes it easy to add the data into the data task and include it if its needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR extends off of #2455, simply adding support for building the required containers and publishing them to ghcr.io
This PR introduces a github workflow to build and publish a docker container that runs grasscutter on
amd64platforms. The base builder container that gradle provides isn't supported for arm64, therefore we can't build for Raspberry Pi's/ARM-based platforms. This might be fixed in the future.Configuration file can be loaded by using
-v C:\\Grasscutter\\test.json:/app/config.jsonIssues fixed by this PR
See #2455
Type of changes
Checklist: